Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub workflows. #48

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update GitHub workflows. #48

wants to merge 2 commits into from

Conversation

myronmarston
Copy link
Collaborator

@myronmarston myronmarston commented Dec 7, 2024 •
edited
Loading

I've adapted a couple recommended workflows from https://github.com/block/example-jvm-maven (scorecard.yaml and security.yaml) and renamed push_gem.yaml to release.yaml.

@myronmarston myronmarston force-pushed the myron/update-github-workflows branch 2 times, most recently from be93f03 to 47dccb6 Compare December 7, 2024 05:09
@myronmarston myronmarston changed the base branch from main to myron/fix-steep December 7, 2024 06:51
@myronmarston
Update GitHub workflows.
b317b54 
I've adapted a couple recommended workflows from https://github.com/block/example-jvm-maven
(`scorecard.yaml` and `security.yaml`) and renamed `push_gem.yaml` to `release.yaml`.
@myronmarston myronmarston force-pushed the myron/update-github-workflows branch from 47dccb6 to b317b54 Compare December 7, 2024 06:51
@github-advanced-security
Copy link
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2024
View reviewed changes
.github/workflows/scorecard.yaml
uses: block/ospo/.github/workflows/scorecard.yml@main
secrets: inherit
permissions:
security-events: write

Check failure

Code scanning / Scorecard

Token-Permissions High

score is 0: jobLevel 'security-events' permission set to 'write'
Remediation tip: Visit https://app.stepsecurity.io/secureworkflow.
Tick the 'Restrict permissions for GITHUB_TOKEN'
Untick other options
NOTE: If you want to resolve multiple issues at once, you can visit https://app.stepsecurity.io/securerepo instead.
Click Remediation section below for further remediation help
.github/workflows/security.yaml
@@ -0,0 +1,23 @@
name: Security and License Scans

Check failure

Code scanning / Scorecard

Token-Permissions High

score is 0: no topLevel permission defined
Remediation tip: Visit https://app.stepsecurity.io/secureworkflow.
Tick the 'Restrict permissions for GITHUB_TOKEN'
Untick other options
NOTE: If you want to resolve multiple issues at once, you can visit https://app.stepsecurity.io/securerepo instead.
Click Remediation section below for further remediation help
Base automatically changed from myron/fix-steep to main December 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSigafoos-SQ BrianSigafoos-SQ Awaiting requested review from BrianSigafoos-SQ BrianSigafoos-SQ will be requested when the pull request is marked ready for review BrianSigafoos-SQ is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@myronmarston